Adjust version parsing in release scripts, fix release dry runs in CI#43568
Closed
huntie wants to merge 1 commit intofacebook:mainfrom
Closed
Adjust version parsing in release scripts, fix release dry runs in CI#43568huntie wants to merge 1 commit intofacebook:mainfrom
huntie wants to merge 1 commit intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55123739 |
huntie
force-pushed
the
export-D55123739
branch
from
d2760a7 to
8040bee
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55123739 |
huntie
force-pushed
the
export-D55123739
branch
from
8040bee to
e88d67d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55123739 |
Base commit: b7c1bd4 |
huntie
changed the title
…facebook#43568) Summary: Fixes to restore passing CI checks on main after D55027120. - Widen validation checks in version utils to accept `0.x.x` (as opposed to `0.[not-'0'].x`). - Use `tag: test` instead of `tag: latest` for dry run job params. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D55123739
huntie
force-pushed
the
export-D55123739
branch
from
e88d67d to
bbe6130
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55123739 |
huntie
force-pushed
the
export-D55123739
branch
from
bbe6130 to
9c8507c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55123739 |
Contributor
|
This pull request has been merged in d03b5dc. |
huntie
added a commit
that referenced
this pull request
Mar 20, 2024
…#43568) Summary: Pull Request resolved: #43568 Fixes to restore passing CI checks on main after D55027120. - Widen validation checks in version utils to accept `0.x.x` (as opposed to `0.[not-'0'].x`). - Use `tag: test` instead of `tag: latest` for dry run job params. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D55123739 fbshipit-source-id: 9f76dced4e7aa3ce87d6680cd7687ae443305331
This was referenced Apr 5, 2024
This was referenced Jun 28, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes to restore passing CI checks on main after D55027120.
0.x.x(as opposed to0.[not-'0'].x).tag: testinstead oftag: latestfor dry run job params.Changelog: [Internal]
Differential Revision: D55123739